Re: [PATCH] net: dsa: qca8k: fix kernel panic with legacy mdio mapping

On Sat, Sep 11, 2021 at 06:40:55PM +0300, Vladimir Oltean wrote:

On Sat, Sep 11, 2021 at 05:36:40PM +0200, Ansuel Smith wrote:

quoted

quoted

quoted

+static int
+qca8k_internal_mdio_write(struct mii_bus *salve_bus, int phy, int regnum, u16 data)
+{
+	struct qca8k_priv *priv = salve_bus->priv;

You are only moving code here but while at it, mind fixing that typo?

I think I didn't understand what you mean here.
Sure I will fix the typo and sorry about it.
Aside from that anything wrong with the 2 new function or there is a
better fix that I can't think of.

"salve" is "hello" in Italian, and even though that is a greeting,
surely that is not what was meant, but rather "slave". So even though
that is less positive, it is at least a technical term with a clear
meaning, so I think Florian's request was to replace "salve" with
"slave" while you are moving the code anyway.

Ok this is embarrassing... Typo by vscode autocorrection... Fixing that
and sending v2. Again sorry.