Re: bridge.c:157:11: error: variable 'err' is used uninitialized whenever 'if' condition is false

On Mon, 2021-09-06 at 20:35 +0300, Vlad Buslov wrote:

On Mon 06 Sep 2021 at 19:39, Linus Torvalds
[off-list ref] wrote:

quoted

On Mon, Sep 6, 2021 at 2:11 AM Naresh Kamboju
[off-list ref] wrote:

quoted

drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c:157:11:
error:
variable 'err' is used uninitialized whenever 'if' condition is
false

That compiler warning (now error) seems to be entirely valid.

I agree, this is a real issue. It had been reported before and my fix
for it was submitted by Saeed last week but wasn't accepted since it
was
part of larger series that also included features and net-next had
already been closed by that time. As far as I understand it is
pending
submission to net as part of series of bug fixes. Sorry for the
delay.

yes, the fix will be submitted shortly to net/rc branch.
due to bad net-next timing the patch couldn't make it to -next.