Re: [PATCH v2 10/14] [net-next] make legacy ISA probe optional
flat view
From: Arnd Bergmann <arnd@kernel.org>
Date: 2021-09-07 13:20:03
Also in:
lkml
On Tue, Sep 7, 2021 at 10:24 AM Geert Uytterhoeven [off-list ref] wrote:
On Wed, Aug 11, 2021 at 4:50 PM Geert Uytterhoeven [off-list ref] wrote:quoted
On Tue, Aug 3, 2021 at 1:41 PM Arnd Bergmann [off-list ref] wrote:quoted
From: Arnd Bergmann <arnd@arndb.de> There are very few ISA drivers left that rely on the static probing from drivers/net/Space.o. Make them all select a new CONFIG_NETDEV_LEGACY_INIT symbol, and drop the entire probe logic when that is disabled. The 9 drivers that are called from Space.c are the same set that calls netdev_boot_setup_check(). Signed-off-by: Arnd Bergmann <arnd@arndb.de>quoted
--- a/drivers/net/ethernet/8390/ne.c +++ b/drivers/net/ethernet/8390/ne.c@@ -951,6 +951,7 @@ static int __init ne_init(void) } module_init(ne_init); +#ifdef CONFIG_NETDEV_LEGACY_INIT struct net_device * __init ne_probe(int unit) { int this_dev;@@ -991,6 +992,7 @@ struct net_device * __init ne_probe(int unit) return ERR_PTR(-ENODEV); } +#endif #endif /* MODULE */My rbtx4927 build log says: drivers/net/ethernet/8390/ne.c:909:20: warning: ‘ne_add_devices’ defined but not used [-Wunused-function]Same for atari_defconfig.
Sorry about that. I made the patch when you first reported it, and I was
sure I had sent it, but apparently not. Sent it now.
Arnd