Re: [PATCH 1/2] irqchip: irq-meson-gpio: make it possible to build as a module

Hi,

On 18/08/2021 13:19, Marc Zyngier wrote:

On Tue, 17 Aug 2021 19:12:34 +0100,
Saravana Kannan [off-list ref] wrote:

quoted

On Tue, Aug 17, 2021 at 12:24 AM Lee Jones [off-list ref] wrote:

quoted

On Mon, 16 Aug 2021, Saravana Kannan wrote:

quoted

quoted

quoted

quoted

I sent out the proper fix as a series:
https://lore.kernel.org/lkml/20210804214333.927985-1-saravanak@google.com/T/#t (local)

Marc, can you give it a shot please?

-Saravana

Superstar!  Thanks for taking the time to rectify this for all of us.

Just to clarify:

  Are we waiting on a subsequent patch submission at this point?

Not that I'm aware of. Andrew added a "Reviewed-by" to all 3 of my
proper fix patches. I didn't think I needed to send any newer patches.
Is there some reason you that I needed to?

Actually, I meant *this* patch.

I think it'll be nice if Neil addresses the stuff Marc mentioned
(ideally) using the macros I suggested. Not sure if Marc is waiting on
that though. Marc also probably wants my mdio-mux series to merge
first before he takes this patch. So that it doesn't break networking
in his device.

Yup. Two things need to happen here:

- the MDIO fixes must be merged (I think they are queued, from what I
  can see)

- the irqchip patch must be fixed so that the driver cannot be
  unloaded (Saravana did explain what needs to be done).

I'll post a re-spin of this serie with the suggested fixes.

Neil

Once these two condition are met, I'll happily take this patch.

	M.