Re: [GIT PULL] Networking for v5.15
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-09-01 19:41:36
Also in:
linux-wireless, lkml
On Wed, 1 Sep 2021 12:00:57 -0700 Linus Torvalds wrote:
On Tue, Aug 31, 2021 at 1:37 PM Jakub Kicinski [off-list ref] wrote:quoted
No conflicts at the time of writing. There were conflicts with char-misc but I believe Greg dropped the commits in question.Hmm. I already merged this earlier, but didn't notice a new warning on my desktop:
RTNL: assertion failed at net/wireless/core.c (61) WARNING: CPU: 60 PID: 1720 at net/wireless/core.c:61 wiphy_idx_to_wiphy+0xbf/0xd0 [cfg80211] Call Trace: nl80211_common_reg_change_event+0xf9/0x1e0 [cfg80211] reg_process_self_managed_hint+0x23d/0x280 [cfg80211] regulatory_set_wiphy_regd_sync+0x3a/0x90 [cfg80211] iwl_mvm_init_mcc+0x170/0x190 [iwlmvm] iwl_op_mode_mvm_start+0x824/0xa60 [iwlmvm] iwl_opmode_register+0xd0/0x130 [iwlwifi] init_module+0x23/0x1000 [iwlmvm] They all seem to have that same issue, and it looks like the fix would be to get the RTN lock in iwl_mvm_init_mcc(), but I didn't really look into it very much. This is on my desktop, and I actually don't _use_ the wireless on this machine. I assume it still works despite the warnings, but they should get fixed. I *don't* see these warnings on my laptop where I actually use wireless, but that one uses ath10k_pci, so it seems this is purely a iwlwifi issue. I can't be the only one that sees this. Hmm?
Mm. Looking thru the recent commits there is a suspicious rtnl_unlock()
in commit eb09ae93dabf ("iwlwifi: mvm: load regdomain at INIT stage").
CC Miri, Johannes