Re: [PATCH][next] igc: remove redundant continue statement
flat view
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Date: 2021-09-01 16:39:01
Also in:
intel-wired-lan, kernel-janitors, lkml
Colin King [off-list ref] writes:
quoted hunk ↗ jump to hunk
From: Colin Ian King <redacted> The continue statement at the end of a for-loop has no effect, remove it. Addresses-Coverity: ("Continue has no effect") Signed-off-by: Colin Ian King <redacted> --- drivers/net/ethernet/intel/igc/igc_ptp.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/net/ethernet/intel/igc/igc_ptp.c b/drivers/net/ethernet/intel/igc/igc_ptp.c index 0f021909b430..b615a980f563 100644 --- a/drivers/net/ethernet/intel/igc/igc_ptp.c +++ b/drivers/net/ethernet/intel/igc/igc_ptp.c@@ -860,7 +860,6 @@ static int igc_phc_get_syncdevicetime(ktime_t *device, * so write the previous error status to clear it. */ wr32(IGC_PTM_STAT, stat); - continue;
Just a bit of background. I added the "continue" here more as documentation: we handled an error, and we want to try again, I felt that the continue helps making that clearer. But I am not completely opposed about removing it.
} } while (--count); -- 2.32.0
Cheers, -- Vinicius