Re: [PATCH nf-next v5 0/6] Netfilter egress hook
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-09-30 16:06:58
Also in:
netfilter-devel
From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-09-30 16:06:58
Also in:
netfilter-devel
On Thu, 30 Sep 2021 17:13:37 +0200 Pablo Neira Ayuso wrote:
On Thu, Sep 30, 2021 at 07:28:35AM -0700, Jakub Kicinski wrote:quoted
The lifetime of this information is constrained, can't it be a percpu flag, like xmit_more?It's just one single bit in this case after all.
??
quoted
quoted
Probably the sysctl for this new egress hook is the way to go as you suggest.Knobs is making users pay, let's do our best to avoid that.Could you elaborate?
My reading of Daniel's objections was that the layering is incorrect because tc is not exclusively "under" nf. That problem is not solved by adding a knob. The only thing the knob achieves is let someone deploying tc/bpf based solution protect themselves from accidental nf deployment. That's just background / level set. IDK what requires explanation in my statement itself. I thought "admin knobs are bad" is as universally agreed on as, say, "testing is good".