Re: [PATCH v2] iplink_rmnet: Allow passing IFLA_RMNET_FLAGS

On 9/27/21 8:48 AM, David Ahern wrote:

quoted

  		} else if (matches(*argv, "help") == 0) {
  			explain();
  			return -1;

use strcmp for new options. Also, please use 'csum' instead of 'chksum'
in the names. csum is already widely used in ip commands.

On the csum remark, I agree completely.

On the other:  Are you saying to use strcmp() instead of
matches()?

That seems strange to me because matches() is used *much*
more often than strcmp(), and handles an empty *argv
differently.

I don't disagree with your suggested change, but upon
looking at the other code it surprises me a bit.  Can
you provide a little more explanation?  If you mean
something else, please clarify.  Thanks.

					-Alex