Thread (7 messages) 7 messages, 3 authors, 2021-09-28

Re: [PATCH net] gve: DQO: Suppress unused var warnings

From: Bailey Forrest <hidden>
Date: 2021-09-27 20:21:46

Apologies, resending as text

On Mon, Sep 27, 2021 at 2:59 AM Arnd Bergmann [off-list ref] wrote:
On Sat, Jul 24, 2021 at 1:19 AM Bailey Forrest [off-list ref] wrote:
quoted
Some variables become unused when `CONFIG_NEED_DMA_MAP_STATE=n`.

We only suppress when `CONFIG_NEED_DMA_MAP_STATE=n` in order to avoid
false negatives.

Fixes: a57e5de476be ("gve: DQO: Add TX path")
Signed-off-by: Bailey Forrest <redacted>
Hi Bailey,

I see that the warning still exists in linux-5.15-rc3 and net-next,
I'm building with my original patch[1] to get around the -Werror
warnings.

Can you resend your patch, or should I resend mine after all?

      Arnd

[1] https://lore.kernel.org/all/20210721151100.2042139-1-arnd@kernel.org/ (local)
Hi David/Jakub,

Any thoughts on my patch? I'm open to alternative suggestions for how
to resolve this.

This patch still works and merges cleanly on HEAD.

Thanks,
Bailey
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help