Re: [PATCH] net: phy: enhance GPY115 loopback disable function
From: Andrew Lunn <andrew@lunn.ch>
Date: 2021-09-24 11:59:59
On Fri, Sep 24, 2021 at 05:05:37PM +0800, Xu Liang wrote:
quoted hunk ↗ jump to hunk
GPY115 need reset PHY when it comes out from loopback mode if the firmware version number (lower 8 bits) is equal to or below 0x76. Signed-off-by: Xu Liang <lxu@maxlinear.com> --- drivers/net/phy/mxl-gpy.c | 30 ++++++++++++++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-)diff --git a/drivers/net/phy/mxl-gpy.c b/drivers/net/phy/mxl-gpy.c index 2d5d5081c3b6..3ef62d5c4776 100644 --- a/drivers/net/phy/mxl-gpy.c +++ b/drivers/net/phy/mxl-gpy.c@@ -493,6 +493,32 @@ static int gpy_loopback(struct phy_device *phydev, bool enable) return ret; } +static int gpy115_loopback(struct phy_device *phydev, bool enable) +{ + int ret; + int fw_minor; + + if (enable) + return gpy_loopback(phydev, enable); + + /* Show GPY PHY FW version in dmesg */
You don't show anything.
+ ret = phy_read(phydev, PHY_FWV);
+ if (ret < 0)
+ return ret;
+
+ fw_minor = FIELD_GET(PHY_FWV_MINOR_MASK, ret);
+ if (fw_minor > 0x0076)
+ return gpy_loopback(phydev, 0);
+
+ ret = phy_modify(phydev, MII_BMCR, BMCR_LOOPBACK, BMCR_RESET);
+ if (!ret) {
+ /* Some delay for the reset complete. */
+ msleep(100);
+ }genphy_soft_reset() would be better. Does a soft reset clear the BMCR_LOOPBACK bit? It should do, according to C22. Andrew