Thread (6 messages) flat view 6 messages, 4 authors, 2021-10-02

Re: [PATCH net-next] net: dsa: sja1105: stop using priv->vlan_aware

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-09-22 18:40:29

On 9/22/21 11:38 AM, Vladimir Oltean wrote:
On Wed, Sep 22, 2021 at 07:24:43PM +0300, Vladimir Oltean wrote:
quoted
On Wed, Sep 22, 2021 at 05:44:01PM +0300, Vladimir Oltean wrote:
quoted
+	if (!dsa_port_is_vlan_filtering(ds, port) &&
omg, what did I just send....
I amended the commit a few times but forgot to format-patch it again.
The dsa_port_is_vlan_filtering prototype takes a "dp" argument, this
patch doesn't even build. Please toss it to the bin where it belongs.
Superseded by v2 which has message ID 20210922183655.2680551-1-vladimir.oltean@nxp.com
Florian, please note that I did not preserve your Reviewed-by tag, due
to the patch looking fairly differently now.
Yes I completely missed that argument misuse, the changes look logically
correct, too quick in reviewing I guess :)
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help