Thread (3 messages) flat view 3 messages, 3 authors, 2021-09-23

Re: [PATCH net-next] net: dsa: sja1105: don't keep a persistent reference to the reset GPIO

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2021-09-22 16:09:41

On 9/22/21 8:10 AM, Vladimir Oltean wrote:
The driver only needs the reset GPIO for a very brief period, so instead
of using devres and keeping the descriptor pointer inside priv, just use
that descriptor inside the sja1105_hw_reset function and then let go of
it.

Also use gpiod_get_optional while at it, and error out on real errors
(bad flags etc).

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help