Re: [RFC PATCH v2 net-next 0/5] Let phylink manage in-band AN for the PHY

Am 2021-09-16 15:54, schrieb Vladimir Oltean:

On Thu, Sep 16, 2021 at 03:51:28PM +0200, Michael Walle wrote:

quoted

Am 2021-09-16 15:09, schrieb Vladimir Oltean:

quoted

On Mon, Aug 30, 2021 at 09:36:23PM +0300, Vladimir Oltean wrote:

quoted

On Mon, Aug 30, 2021 at 07:30:15PM +0100, Russell King (Oracle) wrote:

quoted

Can we postpone this after this merge window please, so I've got time
to properly review this. Thanks.

Please review at your discretion, I've no intention to post a v3 right
now, and to the best of my knowledge, RFC's are not even considered
for
direct inclusion in the git tree.

Hello Russell, can you please review these patches if possible? I
would like to repost them soon.

I planned to test this on my board with the AR8031 (and add support there),
but it seems I won't find time before my vacation, unfortunately.

Oh, but there isn't any "support" to be added I though, your conclusion
last time seemed to be that it only supported in-band autoneg ON?
I was going to add a patch to implement .validate_inband_aneg for the
at803x driver to mark that fact too, I just didn't do it in the RFC.
That should also fix the ENETC ports on the LS1028A-RDB which were
migrated to phylink while they didn't have the 'managed = "in-band-status"'
OF property, and enable new kernels to still work with the old DT blob.
Or were you thinking of something else?

No, but I won't find time to test it within the next.. uhm, 30minutes
until I call it a day ;)

-michael