Thread (4 messages) flat view 4 messages, 4 authors, 2021-09-16

Re: [PATCH] net: wan: wanxl: define CROSS_COMPILE_M68K

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-09-15 03:07:53

On Sun, 12 Sep 2021 23:23:21 +0200 Adam Borowski wrote:
quoted hunk ↗ jump to hunk
It was used but never set.  The hardcoded value from before the dawn of
time was non-standard; the usual name for cross-tools is $TRIPLET-$TOOL

Signed-off-by: Adam Borowski <redacted>
---
 This is neither the host nor target arch, thus it's very unlikely to be
 set by the user.  With this patch, it works out of the box on Debian
 and Fedora.

 drivers/net/wan/Makefile | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/net/wan/Makefile b/drivers/net/wan/Makefile
index f6b92efffc94..480bcd1f6c1c 100644
--- a/drivers/net/wan/Makefile
+++ b/drivers/net/wan/Makefile
@@ -34,6 +34,8 @@ obj-$(CONFIG_SLIC_DS26522)	+= slic_ds26522.o
 clean-files := wanxlfw.inc
 $(obj)/wanxl.o:	$(obj)/wanxlfw.inc
 
+CROSS_COMPILE_M68K = m68k-linux-gnu-
This will not overwrite the parameter if set from command line, right?
My Makefile-foo is getting rusty.
 ifeq ($(CONFIG_WANXL_BUILD_FIRMWARE),y)
 ifeq ($(ARCH),m68k)
   M68KCC = $(CC)
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help