Re: [PATCH net-next] net: wwan: iosm: firmware flashing and coredump collection

On Mon, Sep 13, 2021 at 09:25:54AM -0700, Jakub Kicinski wrote:

On Mon, 13 Sep 2021 18:34:12 +0530 M Chetan Kumar wrote:

quoted

This patch brings-in support for M.2 7560 Device firmware flashing &
coredump collection using devlink.
- Driver Registers with Devlink framework.
- Register devlink params callback for configuring device params
  required in flashing or coredump flow.
- Implements devlink ops flash_update callback that programs modem
  firmware.
- Creates region & snapshot required for device coredump log collection.

On early detection of device in boot rom stage. Driver registers with
Devlink framework and establish transport channel for PSI (Primary Signed
Image) injection. Once PSI is injected to device, the device execution
stage details are read to determine whether device is in flash or
exception mode.

Is this normal operation flow for the device? After each boot device
boots from the rom image and then user has to "inject" the full FW
image with devlink?

If it is, then this sounds like to the wrong interface for
firmware. The driver should be using request_firmware().

	  Andrew