Thread (6 messages) 6 messages, 5 authors, 2021-09-14

Re: [PATCH v3] tcp: fix tp->undo_retrans accounting in tcp_sacktag_one()

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-09-13 15:52:20

On Mon, 30 Aug 2021 05:00:10 -0400 zhenggy wrote:
Commit 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit
time") may directly retrans a multiple segments TSO/GSO packet without
split, Since this commit, we can no longer assume that a retransmitted
packet is a single segment.

This patch fixes the tp->undo_retrans accounting in tcp_sacktag_one()
that use the actual segments(pcount) of the retransmitted packet.

Before that commit (10d3be569243), the assumption underlying the
tp->undo_retrans-- seems correct.

Fixes: 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit time")
Please remove this empty line. There should be no empty lines between
tags.
Signed-off-by: zhenggy <redacted>
Please fix the data on your system and repost. I'm pretty sure this
wasn't posted on Aug 30th.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help