Re: [net 7/7] net/mlx5e: Fix condition when retrieving PTP-rqn
From: Saeed Mahameed <saeedm@nvidia.com>
Date: 2021-09-08 17:34:27
On Wed, 2021-09-08 at 09:39 -0700, Jakub Kicinski wrote:
On Tue, 7 Sep 2021 14:24:20 -0700 Saeed Mahameed wrote:quoted
From: Aya Levin <redacted> When activating the PTP-RQ, redirect the RQT from drop-RQ to PTP- RQ. Use mlx5e_channels_get_ptp_rqn to retrieve the rqn. This helper returns a boolean (not status), hence caller should consider return value 0 as a fail. Change the caller interpretation of the return value.It would be really great to turn down the dial on the abbreviations and add some user-visible impact, as is best practice (some would say a requirement) for fixes.
Ack and agreed ! I will enforce this.
I've been following the PTP work in mlx5 a little bit but I have no idea what a RQT is and what kind of issues to expect without this patch.
RQT is a simple RQ Table; where we group rq numbers in one table object so steering and RSS objects can point to a table of RQs. To simplify driver code: 1. we use RQT objects also for single RQ destinations. 2. HW/FW do not allow destroying RQs when they are directly being referenced by Steering rules. RQTs help keeping steering objects pointing to a valid RQT object while driver is destroying RQs, while re-configuring, we just swap the rq number in the RQT with the new configuration RQs, or when device is deactivated (ifconfig down) we just swap all RQ numbers in all RQTs with the "Drop RQ"