Thread (4 messages) flat view 4 messages, 3 authors, 2021-09-06

Re: [PATCH -net] wireless: iwlwifi: fix printk format warnings in uefi.c

From: Randy Dunlap <hidden>
Date: 2021-09-05 19:07:43
Also in: linux-wireless

On 8/20/21 7:09 PM, Randy Dunlap wrote:
quoted hunk ↗ jump to hunk
The kernel test robot reports printk format warnings in uefi.c, so
correct them.

../drivers/net/wireless/intel/iwlwifi/fw/uefi.c: In function 'iwl_uefi_get_pnvm':
../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:52:30: warning: format '%zd' expects argument of type 'signed size_t', but argument 7 has type 'long unsigned int' [-Wformat=]
    52 |                              "PNVM UEFI variable not found %d (len %zd)\n",
       |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    53 |                              err, package_size);
       |                                   ~~~~~~~~~~~~
       |                                   |
       |                                   long unsigned int
../drivers/net/wireless/intel/iwlwifi/fw/uefi.c:59:29: warning: format '%zd' expects argument of type 'signed size_t', but argument 6 has type 'long unsigned int' [-Wformat=]
    59 |         IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %zd\n", package_size);
       |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~~~
       |                                                                    |
       |                                                                    long unsigned int

Fixes: 84c3c9952afb ("iwlwifi: move UEFI code to a separate file")
Signed-off-by: Randy Dunlap <redacted>
Reported-by: kernel test robot <redacted>
Cc: Kalle Valo <redacted>
Cc: Luca Coelho <redacted>
Cc: linux-wireless@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
---
  drivers/net/wireless/intel/iwlwifi/fw/uefi.c |    4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-next-20210820.orig/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
+++ linux-next-20210820/drivers/net/wireless/intel/iwlwifi/fw/uefi.c
@@ -49,14 +49,14 @@ void *iwl_uefi_get_pnvm(struct iwl_trans
  	err = efivar_entry_get(pnvm_efivar, NULL, &package_size, data);
  	if (err) {
  		IWL_DEBUG_FW(trans,
-			     "PNVM UEFI variable not found %d (len %zd)\n",
+			     "PNVM UEFI variable not found %d (len %lu)\n",
  			     err, package_size);
  		kfree(data);
  		data = ERR_PTR(err);
  		goto out;
  	}
  
-	IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %zd\n", package_size);
+	IWL_DEBUG_FW(trans, "Read PNVM from UEFI with size %lu\n", package_size);
  	*len = package_size;
  
  out:
Hm, no one has commented on this and the robot is still reporting it as
build warnings.
Do I need to resend it?

thanx.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help