Re: [PATCH net-next] net/sched: cls_flower: Add orig_ethtype

From
Ido Schimmel <hidden>
Date
2021-09-02 06:49:08
Reply to
Jamal Hadi Salim, 2021-08-31
On Tue, Aug 31, 2021 at 09:18:16AM -0400, Jamal Hadi Salim wrote:
You have _not_ been unlucky - it is a design issue with flow dissector
and the wrapping around flower. Just waiting to happen for more
other use cases..
I agree. I think the fundamental problem is that flower does not set
'FLOW_DISSECTOR_F_STOP_AT_ENCAP' and simply lets the flow dissector
parse as deep as possible. For example, 'dst_ip' will match on the
inner most destination IP which is not intuitive and probably different
than what most hardware implementations do.

This behavior is also very error prone because it means that if the
kernel learns to dissect a new tunnel protocol, filters can be suddenly
broken (match on outer field now matches on inner field).

I don't think that changing the default behavior is a solution as it can
break user space. Maybe adding a 'stop_encap' flag to flower that user
space will have to set?
Thread (14 messages) 14 messages, 5 authors, last reply 2021-09-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help