Re: [PATCH v3 bpf-next 2/7] bpf: add bpf_trace_vprintk helper
flat view
From: Andrii Nakryiko <hidden>
Date: 2021-08-30 23:35:41
Also in:
bpf
On Fri, Aug 27, 2021 at 10:20 PM Dave Marchevsky [off-list ref] wrote:
This helper is meant to be "bpf_trace_printk, but with proper vararg support". Follow bpf_snprintf's example and take a u64 pseudo-vararg array. Write to /sys/kernel/debug/tracing/trace_pipe using the same mechanism as bpf_trace_printk. Signed-off-by: Dave Marchevsky <redacted> ---
LGTM. Acked-by: Andrii Nakryiko <andrii@kernel.org>
include/linux/bpf.h | 1 + include/uapi/linux/bpf.h | 9 ++++++ kernel/bpf/core.c | 5 ++++ kernel/bpf/helpers.c | 2 ++ kernel/trace/bpf_trace.c | 52 +++++++++++++++++++++++++++++++++- tools/include/uapi/linux/bpf.h | 9 ++++++ 6 files changed, 77 insertions(+), 1 deletion(-)
[...]