Thread (4 messages) flat view 4 messages, 3 authors, 2021-08-16

Re: [PATCH bpf-next] bpf: use kvmalloc in map_lookup_elem

From: Daniel Borkmann <daniel@iogearbox.net>
Date: 2021-08-16 21:43:25
Also in: bpf

On 8/16/21 6:48 PM, Stanislav Fomichev wrote:
quoted hunk ↗ jump to hunk
Use kvmalloc/kvfree for temporary value when looking up a map.
kmalloc might not be sufficient for percpu maps where the value is big.

Can be reproduced with netcnt test on qemu with "-smp 255".

Signed-off-by: Stanislav Fomichev <redacted>
---
  kernel/bpf/syscall.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
index 9a2068e39d23..ae0b1c1c8ece 100644
--- a/kernel/bpf/syscall.c
+++ b/kernel/bpf/syscall.c
@@ -1076,7 +1076,7 @@ static int map_lookup_elem(union bpf_attr *attr)
  	value_size = bpf_map_value_size(map);
  
  	err = -ENOMEM;
-	value = kmalloc(value_size, GFP_USER | __GFP_NOWARN);
+	value = kvmalloc(value_size, GFP_USER | __GFP_NOWARN);
  	if (!value)
  		goto free_key;
What about other cases like map_update_elem(), shouldn't they be adapted
similarly?

Thanks,
Daniel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help