Thread (12 messages) flat view 12 messages, 3 authors, 2021-08-12

Re: [PATCH v4 bpf-next 3/3] selftest/bpf: Implement sample UNIX domain socket iterator program.

From: Yonghong Song <hidden>
Date: 2021-08-10 23:47:10
Also in: bpf


On 8/10/21 2:28 AM, Kuniyuki Iwashima wrote:
The iterator can output the same result compared to /proc/net/unix.

   # cat /sys/fs/bpf/unix
   Num       RefCount Protocol Flags    Type St Inode Path
   ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer
There seems a misalignment between header line and data line.
I know /proc/net/unix having this issue as well. But can we adjust 
spacing in bpf program to make header/data properly aligned?
   ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@World@

   # cat /proc/net/unix
   Num       RefCount Protocol Flags    Type St Inode Path
   ffff9ab7122db000: 00000002 00000000 00010000 0001 01 10623 private/defer
   ffff9fca0023d000: 00000002 00000000 00000000 0001 01 11058 @Hello@World@

Note that this prog requires the patch ([0]) for LLVM code gen.  Thanks to
Yonghong Song for analysing and fixing.

[0] https://reviews.llvm.org/D107483

Signed-off-by: Kuniyuki Iwashima <redacted>
LGTM. Thanks!

Acked-by: Yonghong Song <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help