Re: [PATCH bpf-next v2] selftests/bpf: move netcnt test under test_progs

On Mon, Aug 2, 2021 at 10:39 AM Stanislav Fomichev [off-list ref] wrote:

Rewrite to skel and ASSERT macros as well while we are at it.

v2:
- don't check result of bpf_map__fd (Yonghong Song)
- remove from .gitignore (Andrii Nakryiko)
- move ping_command into network_helpers (Andrii Nakryiko)
- remove assert() (Andrii Nakryiko)

Signed-off-by: Stanislav Fomichev <redacted>
Acked-by: Yonghong Song <redacted>
---

netcnt selftest is failing in our CI ([0]), PTAL. xdp_context_test_run
failure is unrelated, ignore that one.

  [0] https://github.com/kernel-patches/bpf/runs/3225481504?check_suite_focus=true

 tools/testing/selftests/bpf/.gitignore        |   1 -
 tools/testing/selftests/bpf/Makefile          |   3 +-
 tools/testing/selftests/bpf/network_helpers.c |  12 ++
 tools/testing/selftests/bpf/network_helpers.h |   1 +
 .../testing/selftests/bpf/prog_tests/netcnt.c |  82 ++++++++++
 .../selftests/bpf/prog_tests/tc_redirect.c    |  12 --
 tools/testing/selftests/bpf/test_netcnt.c     | 148 ------------------
 7 files changed, 96 insertions(+), 163 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/netcnt.c
 delete mode 100644 tools/testing/selftests/bpf/test_netcnt.c

[...]