Thread (55 messages) flat view 55 messages, 4 authors, 2021-08-10

Re: [PATCH v10 02/17] file: Export receive_fd() to modules

From: Jason Wang <hidden>
Date: 2021-08-03 07:46:22
Also in: kvm, linux-fsdevel, linux-iommu, lkml, virtualization

在 2021/7/29 下午3:34, Xie Yongji 写道:
quoted hunk ↗ jump to hunk
Export receive_fd() so that some modules can use
it to pass file descriptor between processes without
missing any security stuffs.

Signed-off-by: Xie Yongji <redacted>
---
  fs/file.c            | 6 ++++++
  include/linux/file.h | 7 +++----
  2 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/fs/file.c b/fs/file.c
index 86dc9956af32..210e540672aa 100644
--- a/fs/file.c
+++ b/fs/file.c
@@ -1134,6 +1134,12 @@ int receive_fd_replace(int new_fd, struct file *file, unsigned int o_flags)
  	return new_fd;
  }
  
+int receive_fd(struct file *file, unsigned int o_flags)
+{
+	return __receive_fd(file, NULL, o_flags);

Any reason that receive_fd_user() can live in the file.h?

Thanks

quoted hunk ↗ jump to hunk
+}
+EXPORT_SYMBOL_GPL(receive_fd);
+
  static int ksys_dup3(unsigned int oldfd, unsigned int newfd, int flags)
  {
  	int err = -EBADF;
diff --git a/include/linux/file.h b/include/linux/file.h
index 2de2e4613d7b..51e830b4fe3a 100644
--- a/include/linux/file.h
+++ b/include/linux/file.h
@@ -94,6 +94,9 @@ extern void fd_install(unsigned int fd, struct file *file);
  
  extern int __receive_fd(struct file *file, int __user *ufd,
  			unsigned int o_flags);
+
+extern int receive_fd(struct file *file, unsigned int o_flags);
+
  static inline int receive_fd_user(struct file *file, int __user *ufd,
  				  unsigned int o_flags)
  {
@@ -101,10 +104,6 @@ static inline int receive_fd_user(struct file *file, int __user *ufd,
  		return -EFAULT;
  	return __receive_fd(file, ufd, o_flags);
  }
-static inline int receive_fd(struct file *file, unsigned int o_flags)
-{
-	return __receive_fd(file, NULL, o_flags);
-}
  int receive_fd_replace(int new_fd, struct file *file, unsigned int o_flags);
  
  extern void flush_delayed_fput(void);
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help