Re: [PATCH] cxgb4: remove unneeded variable
From: Heiner Kallweit <hkallweit1@gmail.com>
Date: 2021-08-31 08:08:06
Also in:
lkml
On 31.08.2021 08:22, cgel.zte@gmail.com wrote:
From: Chi Minghao <redacted> Fix the following coccicheck REVIEW: ./drivers/net/ethernet/chelsio/cxgb4/t4_hw.c:3266:5-8 REVIEW Unneeded variable Reported-by: Zeal Robot <redacted> Signed-off-by: Chi Minghao <redacted>
This patch is simply wrong and obviously not even compile-tested. You would have found out by looking 5s at the code of the function. Look at what the FIRST_RET macro is doing. Please don't blindly trust tools and check patches proposed by tools.
quoted hunk ↗ jump to hunk
--- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index 5e8ac42ac6ab..c986a414414b 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c@@ -3263,8 +3263,6 @@ int t4_get_scfg_version(struct adapter *adapter, u32 *vers) */ int t4_get_version_info(struct adapter *adapter) { - int ret = 0; - #define FIRST_RET(__getvinfo) \ do { \ int __ret = __getvinfo; \@@ -3280,7 +3278,7 @@ int t4_get_version_info(struct adapter *adapter) FIRST_RET(t4_get_vpd_version(adapter, &adapter->params.vpd_vers)); #undef FIRST_RET - return ret; + return 0; } /**