Thread (4 messages) 4 messages, 4 authors, 2021-08-31

Re: [PATCH] net: sched: Fix qdisc_rate_table refcount leak when get tcf_block failed

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2021-08-30 18:05:55
Also in: lkml

On Sun, 29 Aug 2021 23:58:01 +0800 Xiyu Yang wrote:
The reference counting issue happens in one exception handling path of
cbq_change_class(). When failing to get tcf_block, the function forgets
to decrease the refcount of "rtab" increased by qdisc_put_rtab(),
causing a refcount leak.

Fix this issue by jumping to "failure" label when get tcf_block failed.

Signed-off-by: Xiyu Yang <redacted>
Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help