Re: [PATCH net-next 2/2] skbuff: keep track of pp page when __skb_frag_ref() is called

Hi Yunsheng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Yunsheng-Lin/some-optimization-for-page-pool/20210830-092301
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git eaf2aaec0be4623b1d19f5c6ef770a78a91cf460
config: sparc64-randconfig-r035-20210829 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8d228f2ead7e21fe408d1e970132df9d13562a80
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yunsheng-Lin/some-optimization-for-page-pool/20210830-092301
        git checkout 8d228f2ead7e21fe408d1e970132df9d13562a80
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

   In file included from include/net/net_namespace.h:39,
                    from include/linux/inet.h:42,
                    from arch/sparc/kernel/setup_64.c:27:
   include/linux/skbuff.h: In function '__skb_frag_ref':

quoted

include/linux/skbuff.h:3076:22: error: unused variable 'page' [-Werror=unused-variable]

    3076 |         struct page *page = skb_frag_page(frag);
         |                      ^~~~
   arch/sparc/kernel/setup_64.c: At top level:
   arch/sparc/kernel/setup_64.c:615:13: error: no previous prototype for 'alloc_irqstack_bootmem' [-Werror=missing-prototypes]
     615 | void __init alloc_irqstack_bootmem(void)
         |             ^~~~~~~~~~~~~~~~~~~~~~
   cc1: all warnings being treated as errors
--
   In file included from include/linux/if_ether.h:19,
                    from include/linux/etherdevice.h:20,
                    from arch/sparc/kernel/idprom.c:13:
   include/linux/skbuff.h: In function '__skb_frag_ref':

quoted

include/linux/skbuff.h:3076:22: error: unused variable 'page' [-Werror=unused-variable]

    3076 |         struct page *page = skb_frag_page(frag);
         |                      ^~~~
   cc1: all warnings being treated as errors


vim +/page +3076 include/linux/skbuff.h

  3067	
  3068	/**
  3069	 * __skb_frag_ref - take an addition reference on a paged fragment.
  3070	 * @frag: the paged fragment
  3071	 *
  3072	 * Takes an additional reference on the paged fragment @frag.
  3073	 */
  3074	static inline void __skb_frag_ref(skb_frag_t *frag)
  3075	{

3076		struct page *page = skb_frag_page(frag);

  3077	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org