RE: [PATCH] rtlwifi: rtl8192de: Restore channel index initialization

-----Original Message-----
From: Kees Cook [mailto:keescook@chromium.org]
Sent: Thursday, August 26, 2021 10:36 AM
To: Pkshih
Cc: Kalle Valo; David S. Miller; Jakub Kicinski; Larry Finger; Colin Ian King; Kaixu Xia; Joe Perches;
linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org;
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] rtlwifi: rtl8192de: Restore channel index initialization

On Thu, Aug 26, 2021 at 12:45:53AM +0000, Pkshih wrote:

quoted

quoted

-----Original Message-----
From: Kees Cook [mailto:keescook@chromium.org]
Sent: Thursday, August 26, 2021 2:31 AM
To: Pkshih
Cc: Kees Cook; Kalle Valo; David S. Miller; Jakub Kicinski; Larry Finger; Colin Ian King; Kaixu

Xia;

quoted

quoted

Joe Perches; linux-wireless@vger.kernel.org; netdev@vger.kernel.org;

linux-kernel@vger.kernel.org;

quoted

quoted

linux-hardening@vger.kernel.org
Subject: [PATCH] rtlwifi: rtl8192de: Restore channel index initialization

2G channel indexes still need "place" to be initialized, since it is
returned from this function when channel is less than 14.

Fixes: 369956ae5720 ("rtlwifi: rtl8192de: Remove redundant variable initializations")

Like the patch "rtlwifi: rtl8192de: Fix initialization of place in _rtl92c_phy_get_rightchnlplace()"
you sent before, please help to correct the removal of the commit 369956ae5720.
I think we can add following into this patch.

--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c

@@ -1363,7 +1363,7 @@ static void _rtl92d_phy_switch_rf_setting(struct ieee80211_hw *hw, u8 channel)

 u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl)
 {
-       u8 place = chnl;
+       u8 place;

        if (chnl > 14) {
                for (place = 14; place < sizeof(channel_all); place++) {

Oh, er, it looks like Nathan found this before me, yes. I think
https://lore.kernel.org/linux-wireless/20210823222014.764557-1-nathan@kernel.org/ (local)
is the complete patch.

Oops. Sorry, I misread the author who isn't you.