Re: [PATCH net-next] net: dsa: mt7530: manually set up VLAN ID 0

On Tue, Aug 24, 2021 at 08:37:14PM +0300, Vladimir Oltean wrote:

On Wed, Aug 25, 2021 at 01:32:37AM +0800, DENG Qingfang wrote:

quoted

Okay. So the Fixes tag should be 6087175b7991, which initially adds the
software fallback support for mt7530.

Ok. Did the old code not need VLAN 0 for VLAN-unaware ports, or are you
saying that since the VLAN table lookup was bypassed completely in the
old code, 'no VLAN 0' was an inconsequential error?

I think it's the latter. Just wanted to make sure. So that means, either
this Fixes: tag or the other, the patch still belongs to net-next. From
my side you shouldn't need to resend.

You're right. The old code does not use VLAN table lookup for VLAN-unaware
ports, and the current code set VLAN-unaware ports to fallback mode so
missing VLAN 0 will only make them fallback to SVL.

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>