Thread (4 messages) 4 messages, 3 authors, 2021-09-29

Re: [PATCH] selftests/bpf: Use kselftest skip code for skipped tests

From: Dylan Hatch <hidden>
Date: 2021-08-25 01:32:48
Also in: bpf, linux-kselftest, lkml

On Sun, Aug 22, 2021 at 8:12 PM Po-Hsu Lin [off-list ref] wrote:
There are several test cases in the bpf directory are still using
exit 0 when they need to be skipped. Use kselftest framework skip
code instead so it can help us to distinguish the return status.

Criterion to filter out what should be fixed in bpf directory:
  grep -r "exit 0" -B1 | grep -i skip

This change might cause some false-positives if people are running
these test scripts directly and only checking their return codes,
which will change from 0 to 4. However I think the impact should be
small as most of our scripts here are already using this skip code.
And there will be no such issue if running them with the kselftest
framework.

Signed-off-by: Po-Hsu Lin <redacted>
Reviewed-By: Dylan Hatch <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help