Re: [PATCH v3 net-next] net: bridge: change return type of br_handle_ingress_vlan_tunnel

On Mon, 23 Aug 2021 13:25:20 +0300 Nikolay Aleksandrov wrote:

On 23/08/2021 13:21, Kangmin Park wrote:

quoted

br_handle_ingress_vlan_tunnel() is only referenced in
br_handle_frame(). If br_handle_ingress_vlan_tunnel() is called and
return non-zero value, goto drop in br_handle_frame().

But, br_handle_ingress_vlan_tunnel() always return 0. So, the
routines that check the return value and goto drop has no meaning.

Therefore, change return type of br_handle_ingress_vlan_tunnel() to
void and remove if statement of br_handle_frame().

Signed-off-by: Kangmin Park <redacted>

Looks good to me,
Acked-by: Nikolay Aleksandrov <redacted>

Applied, thanks!