Thread (4 messages) flat view 4 messages, 3 authors, 2021-08-24

Re: [PATCH linux-next] tools:test_xdp_noinline: fix boolreturn.cocci warnings

From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2021-08-24 15:52:07
Also in: linux-kselftest, lkml

On 8/24/21 8:46 AM, Jakub Kicinski wrote:
On Tue, 24 Aug 2021 08:42:15 -0600 Shuah Khan wrote:
quoted
On 8/24/21 12:55 AM, CGEL wrote:
quoted
From: Jing Yangyang <redacted>

Return statements in functions returning bool should use true/false
instead of 1/0.

Reported-by: Zeal Robot <redacted>
Signed-off-by: Jing Yangyang <redacted>
We can't accept this patch. The from and Signed-off-by don't match.
That's what I thought but there is a From in the email body which git
will pick up. The submission is correct.
Missed that. Thanks.
Please trim your responses.
Will do.

thanks,
-- Shuah
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help