Re: [PATCH v2] of: property: fw_devlink: Add support for "phy-handle" property
From: Marek Szyprowski <m.szyprowski@samsung.com>
Date: 2021-08-23 12:08:56
Also in:
linux-amlogic, linux-devicetree, lkml
Hi, On 18.08.2021 04:17, Saravana Kannan wrote:
Allows tracking dependencies between Ethernet PHYs and their consumers. Cc: Andrew Lunn <andrew@lunn.ch> Cc: netdev@vger.kernel.org Signed-off-by: Saravana Kannan <redacted>
This patch landed recently in linux-next as commit cf4b94c8530d ("of:
property: fw_devlink: Add support for "phy-handle" property"). It breaks
ethernet operation on my Amlogic-based ARM64 boards: Odroid C4
(arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts) and N2
(meson-g12b-odroid-n2.dts) as well as Khadas VIM3/VIM3l
(meson-g12b-a311d-khadas-vim3.dts and meson-sm1-khadas-vim3l.dts).
In case of OdroidC4 I see the following entries in the
/sys/kernel/debug/devices_deferred:
ff64c000.mdio-multiplexer
ff3f0000.ethernet
Let me know if there is anything I can check to help debugging this issue.
quoted hunk ↗ jump to hunk
--- v1 -> v2: - Fixed patch to address my misunderstanding of how PHYs get initialized. drivers/of/property.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/of/property.c b/drivers/of/property.c index 931340329414..0c0dc2e369c0 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c@@ -1291,6 +1291,7 @@ DEFINE_SIMPLE_PROP(pwms, "pwms", "#pwm-cells") DEFINE_SIMPLE_PROP(resets, "resets", "#reset-cells") DEFINE_SIMPLE_PROP(leds, "leds", NULL) DEFINE_SIMPLE_PROP(backlight, "backlight", NULL) +DEFINE_SIMPLE_PROP(phy_handle, "phy-handle", NULL) DEFINE_SUFFIX_PROP(regulators, "-supply", NULL) DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")@@ -1379,6 +1380,7 @@ static const struct supplier_bindings of_supplier_bindings[] = { { .parse_prop = parse_resets, }, { .parse_prop = parse_leds, }, { .parse_prop = parse_backlight, }, + { .parse_prop = parse_phy_handle, }, { .parse_prop = parse_gpio_compat, }, { .parse_prop = parse_interrupts, }, { .parse_prop = parse_regulators, },
Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland