Re: [PATCH v1 net-next 4/7] ptp_pch: Switch to use module_pci_driver() macro
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2021-08-23 08:29:14
Also in:
lkml, oe-kbuild-all
On Fri, Aug 13, 2021 at 11:23:12AM -0700, Jakub Kicinski wrote:
On Fri, 13 Aug 2021 18:39:14 +0300 Andy Shevchenko wrote:quoted
On Fri, Aug 13, 2021 at 06:13:21PM +0300, Andy Shevchenko wrote:quoted
On Fri, Aug 13, 2021 at 10:34:17PM +0800, kernel test robot wrote:
quoted
quoted
quoted
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <redacted>Thanks! Definitely I have compiled it in my local branch. I'll check what is the root cause of this.Kconfig misses PCI dependency. I will send a separate patch, there is nothing to do here.That patch has to be before this one, tho. There is a static inline stub for pci_register_driver() etc. if !PCI, but there isn't for module_pci_driver(), meaning in builds without PCI this driver used to be harmlessly pointless, now it's breaking build. Am I missing something?
Because the PCI dependency has been restored, can we now apply this series? FYI, It was also reported that without PCI dependency and even w/o this path the build can be broken on some architectures due to other reasons (PCI_IOBASE is one of them IIRC). -- With Best Regards, Andy Shevchenko