Re: [PATCH] net: xfrm: assign the per_cpu_ptr pointer before return
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: 2021-08-18 03:32:31
Also in:
lkml, stable
On Wed, Aug 18, 2021 at 11:25:53AM +0800, Dongliang Mu wrote:
quoted hunk ↗ jump to hunk
diff --git a/net/xfrm/xfrm_ipcomp.c b/net/xfrm/xfrm_ipcomp.c index cb40ff0ff28d..01dbec70dfba 100644 --- a/net/xfrm/xfrm_ipcomp.c +++ b/net/xfrm/xfrm_ipcomp.c@@ -223,9 +223,9 @@ static void * __percpu *ipcomp_alloc_scratches(void) void *scratch; scratch = vmalloc_node(IPCOMP_SCRATCH_SIZE, cpu_to_node(i)); + *per_cpu_ptr(scratches, i) = scratch; if (!scratch) return NULL; - *per_cpu_ptr(scratches, i) = scratch;
scratches comes from alloc_percpu so it should already be zeroed. Cheers, -- Email: Herbert Xu [off-list ref] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt