Thread (18 messages) flat view 18 messages, 4 authors, 2021-08-20

RE: [PATCH net-next 1/1] net: phy: marvell10g: Add WAKE_PHY support to WOL event

From: Song, Yoong Siang <hidden>
Date: 2021-08-16 03:19:40
Also in: lkml

quoted
How does this work if the driver has no interrupt support? What is the
hardware setup this has been tested with?
Hi Russell

We already know from previous patches that the Intel hardware is broken,
and does not actually deliver the interrupt which caused the wake up. So i
assume this just continues on with the same broken hardware, but they have
a different PHY connected.
Hi Russell & Andrew,

This is tested on Intel Elkhart Lake (EHL) board. We are using polling mode.
Both WoL interrupt and link change interrupt are the same pin which is
routed to PMC. PMC will wake up the system when there is WoL event.

Regards
Siang
quoted
What if we later want to add interrupt support to this driver to
support detecting changes in link state - isn't using this bit in the
interrupt enable register going to confict with that?
Agreed. If the interrupt register is being used, i think we need this patchset to
add proper interrupt support. Can you recommend a board they can buy off
the shelf with the interrupt wired up? Or maybe Intel can find a hardware
engineer to add a patch wire to link the interrupt output to a SoC pin that can
do interrupts.

	  Andrew
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help