Thread (3 messages) 3 messages, 2 authors, 2021-08-13

Re: [PATCH v2 1/2] rtl8xxxu: unset the hw capability HAS_RATE_CONTROL

flat view

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-08-13 08:26:35
Also in: linux-wireless, lkml

On Fri, 2021-06-11 at 22:47 +0800, Chris Chiu wrote:
Based on the description in
https://github.com/torvalds/linux/blob/master/net/mac80211/agg-tx.c#L32
to L36, if we set HAS_RATE_CONTROL, which means we don't want the
software rate control (default minstrel), then we will have to deal
with both the rate control and the TX aggregation in the driver, and
the .ampdu_action is not really required. 
I don't think this is true. You'll probably still want to use the A-MPDU
state machine in mac80211, etc.

What you *don't* get without rate control in mac80211 is any decision on
whether or not to enable A-MPDU, but that's something you can easily do
elsewhere and just call ieee80211_start_tx_ba_session() at an
appropriate point in time.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help