Re: [PATCH net-next v3 5/6] net: dsa: qca: ar9331: add bridge support
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-08-07 23:08:45
Also in:
linux-mips, lkml
From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-08-07 23:08:45
Also in:
linux-mips, lkml
Hi Oleksij, On Mon, Aug 02, 2021 at 03:10:36PM +0200, Oleksij Rempel wrote:
This switch is providing forwarding matrix, with it we can configure individual bridges. Potentially we can configure more than one not VLAN based bridge on this HW. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> ---
I don't see anywhere in this patch or in this series that the tag_ar9331.c file is being patched to set skb->offload_fwd_mark to true for packets sent (flooded) to the CPU that have already been forwarded by the hardware switch. If the software bridge sees a broadcast packet coming from your driver and it has offload_fwd_mark = false, it will forward it a second time and the other nodes in your network will see duplicates.