Thread (14 messages) flat view 14 messages, 3 authors, 2021-08-06

Re: [PATCH net-next 2/6] net: ipa: reorder netdev pointer assignments

From: Alex Elder <hidden>
Date: 2021-08-06 11:39:57
Also in: lkml

On 8/5/21 8:27 PM, Jakub Kicinski wrote:
On Wed,  4 Aug 2021 10:36:22 -0500 Alex Elder wrote:
quoted
Assign the ipa->modem_netdev and endpoint->netdev pointers *before*
registering the network device.  As soon as the device is
registered it can be opened, and by that time we'll want those
pointers valid.

Similarly, don't make those pointers NULL until *after* the modem
network device is unregistered in ipa_modem_stop().

Signed-off-by: Alex Elder <redacted>
This one seems like a pretty legit race, net would be better if you
don't mind.
I don't mind at all.  But now that it's accepted, I'm not sure how
to go about getting it back-ported.  Mainly I don't want to interfere
with any interaction between net/master and net-next/master...  Maybe
you're in a better position to do that.  And if so:

Fixes: 57f63faf0562 ("net: ipa: only set endpoint netdev pointer when in 
use")

I'll happily do it if you can tell me the best way how.  Thanks.

					-Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help