Thread (26 messages) 26 messages, 9 authors, 2021-08-30

Re: [PATCH v5 04/14] scsi: megaraid_sas: Use irq_set_affinity_and_hint

flat view

From: Sumit Saxena <sumit.saxena@broadcom.com>
Date: 2021-08-06 11:31:49
Also in: intel-wired-lan, linux-api, linux-pci, linux-scsi, lkml

On Wed, Jul 21, 2021 at 4:57 AM Nitesh Narayan Lal [off-list ref] wrote:
The driver uses irq_set_affinity_hint() specifically for the high IOPS
queue interrupts for two purposes:

- To set the affinity_hint which is consumed by the userspace for
  distributing the interrupts

- To apply an affinity that it provides

The driver enforces its own affinity to bind the high IOPS queue interrupts
to the local NUMA node. However, irq_set_affinity_hint() applying the
provided cpumask as an affinity for the interrupt is an undocumented side
effect.

To remove this side effect irq_set_affinity_hint() has been marked
as deprecated and new interfaces have been introduced. Hence, replace the
irq_set_affinity_hint() with the new interface irq_set_affinity_and_hint()
where the provided mask needs to be applied as the affinity and
affinity_hint pointer needs to be set and replace with
irq_update_affinity_hint() where only affinity_hint needs to be updated.

Change the megasas_set_high_iops_queue_affinity_hint function name to
megasas_set_high_iops_queue_affinity_and_hint to clearly indicate that the
function is setting both affinity and affinity_hint.

Signed-off-by: Nitesh Narayan Lal <redacted>
Looks good.
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help