Re: [PATCH][next] brcmfmac: firmware: Fix uninitialized variable ret

On 06/08/2021 12:23, Arend van Spriel wrote:

On 05-08-2021 15:53, Kalle Valo wrote:

quoted

Linus Walleij [off-list ref] writes:

quoted

On Tue, Aug 3, 2021 at 5:09 PM Colin King [off-list ref]
wrote:

quoted

From: Colin Ian King <redacted>

Currently the variable ret is uninitialized and is only set if
the pointer alt_path is non-null. Fix this by ininitializing ret
to zero.

Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware
binaries")
Signed-off-by: Colin Ian King <redacted>

Nice catch!
Reviewed-by: Linus Walleij <redacted>

I assume this will be fixed by Linus' patch "brcmfmac: firmware: Fix
firmware loading" and I should drop Colin's patch, correct?

That would be my assumption as well, but not sure when he will submit
another revision of it. You probably know what to do ;-)

I'd prefer my patch to be dropped in preference to Linus' fix.

Regards,
Arend