Re: [PATCH net-next] net: Remove redundant if statements

August 6, 2021 4:58 PM, "Matthieu Baerts" [off-list ref] wrote:

Hi Yajun,

Thank you for sharing this patch.

On 06/08/2021 08:38, Yajun Deng wrote:

quoted

The if statement already move into sock_{put , hold},
just remove it.

I was wondering in which subtree you had 'sock_put' checking the socket
pointer but then I realised you sent another patch just before adding
this check: "net: sock: add the case if sk is NULL"

Please next time send them in the same series to clearly indicate that
this is the 2nd patch (2/2) and it depends on patch 1/2.

OK, Thank you for your advice.

Related to the modification in MPTCP part: it looks OK but we do a few
other calls to 'sock_put()' where we don't need to check if the socket
is NULL or not.

In other words, if your patch "net: sock: add the case if sk is NULL" is
accepted, then the modification in "net/mptcp/subflow.c" is OK for us.

Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net