Re: [RFC PATCH v1 1/7] virtio/vsock: add 'VIRTIO_VSOCK_SEQ_EOM' bit
From: Stefano Garzarella <sgarzare@redhat.com>
Date: 2021-08-06 07:19:12
Also in:
kvm, lkml, virtualization
On Mon, Jul 26, 2021 at 07:33:04PM +0300, Arseny Krasnov wrote:
quoted hunk ↗ jump to hunk
This bit is used to mark end of messages('EOM' - end of message), while 'VIRIO_VSOCK_SEQ_EOR' is used to pass MSG_EOR. Signed-off-by: Arseny Krasnov <redacted> --- include/uapi/linux/virtio_vsock.h | 1 + 1 file changed, 1 insertion(+)diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h index 3dd3555b2740..1de3211a2988 100644 --- a/include/uapi/linux/virtio_vsock.h +++ b/include/uapi/linux/virtio_vsock.h@@ -98,6 +98,7 @@ enum virtio_vsock_shutdown {/* VIRTIO_VSOCK_OP_RW flags values */ enum virtio_vsock_rw { VIRTIO_VSOCK_SEQ_EOR = 1, + VIRTIO_VSOCK_SEQ_EOM = 2, };
Already said, but I'll repeat it for completeness. It's better to rename the flag 1 and use it in the same way we did before, so it's backward compatible. Obviously we have to update the specifications too, explaining the difference between the two :-) Thanks, Stefano