RE: [PATCH net-next v3] ethernet: fix PTP_1588_CLOCK dependencies

-----Original Message-----
From: Arnd Bergmann <arnd@kernel.org>
Sent: Wednesday, August 04, 2021 8:21 AM
To: Richard Cochran <richardcochran@gmail.com>
Cc: David S. Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>;
Keller, Jacob E [off-list ref]; Arnd Bergmann [off-list ref];
Andrew Lunn [off-list ref]; Vivien Didelot [off-list ref];
Florian Fainelli [off-list ref]; Vladimir Oltean [off-list ref];
Claudiu Manoil [off-list ref]; Alexandre Belloni
[off-list ref]; Microchip Linux Driver Support
[off-list ref]; Nicolas Ferre
[off-list ref]; Claudiu Beznea
[off-list ref]; Yisen Zhuang [off-list ref];
Salil Mehta [off-list ref]; Brandeburg, Jesse
[off-list ref]; Nguyen, Anthony L
[off-list ref]; Tariq Toukan [off-list ref]; Saeed
Mahameed [off-list ref]; Leon Romanovsky [off-list ref]; Jiri
Pirko [off-list ref]; Ido Schimmel [off-list ref]; Shannon Nelson
[off-list ref]; drivers@pensando.io; Sergei Shtylyov
[off-list ref]; Edward Cree [off-list ref]; Martin
Habets [off-list ref]; Giuseppe Cavallaro
[off-list ref]; Alexandre Torgue [off-list ref];
Jose Abreu [off-list ref]; Heiner Kallweit [off-list ref];
Russell King [off-list ref]; Yangbo Lu [off-list ref]; Randy
Dunlap [off-list ref]; Simon Horman
[off-list ref]; Networking [off-list ref];
Linux Kernel Mailing List [off-list ref]; Intel Wired LAN <intel-
wired-lan@lists.osuosl.org>
Subject: Re: [PATCH net-next v3] ethernet: fix PTP_1588_CLOCK dependencies

On Wed, Aug 4, 2021 at 4:28 PM Richard Cochran [off-list ref]
wrote:

quoted

quoted

@@ -87,8 +87,8 @@ config E1000E_HWTS
 config IGB
      tristate "Intel(R) 82575/82576 PCI-Express Gigabit Ethernet support"
      depends on PCI
-     imply PTP_1588_CLOCK
-     select I2C
+     depends on PTP_1588_CLOCK_OPTIONAL
+     depends on I2C

This little i2c bit sneaks in, but I guess you considered any possible
trouble with it?

Good catch!

I did need this with v2, as it was causing a circular dependency against
(IIRC) CONFIG_MLXSW_I2C, but I'm fairly sure it's not needed any
more after everything else uses 'depends on' now.

I'm happy to resend a v4 without that change, as it doesn't belong in here,
or we just leave it because it is correct after all, depending on what the Intel
ethernet people prefer.

I'm fine with keeping it in.

quoted

Acked-by: Richard Cochran <richardcochran@gmail.com>

Thanks,

      Arnd