Thread (6 messages) flat view 6 messages, 1 author, 2021-08-03
DORMANTno replies REVIEWED: 1 (0M)

1 review trailer.

[PATCH ethtool-next 5/5] man: mention XDP standard statistics in help and man page

From: Alexander Lobakin <hidden>
Date: 2021-08-03 16:52:33
Also in: bpf, linux-doc, lkml
Subsystem: the rest · Maintainer: Linus Torvalds

"xdp" is a new type of standard statistics landed in with Linux
commit a9428aaed122 ("ethtool, stats: introduce standard XDP statistics").
Mention it in the help text and the man page source.

Signed-off-by: Alexander Lobakin <redacted>
Reviewed-by: Jesse Brandeburg <redacted>
---
 ethtool.8.in | 3 ++-
 ethtool.c    | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/ethtool.8.in b/ethtool.8.in
index 6b7761849fca..7db0adebbdcf 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
@@ -245,6 +245,7 @@ ethtool \- query or control network driver and hardware settings
 .RB [\fBeth\-mac\fP]
 .RB [\fBeth\-ctrl\fP]
 .RB [\fBrmon\fP]
+.RB [\fBxdp\fP]
 .RB ]
 .HP
 .B ethtool \-\-phy\-statistics
@@ -673,7 +674,7 @@ naming of NIC- and driver-specific statistics across vendors.
 .B \fB\-\-all\-groups
 .E
 .TP
-.B \fB\-\-groups [\fBeth\-phy\fP] [\fBeth\-mac\fP] [\fBeth\-ctrl\fP] [\fBrmon\fP]
+.B \fB\-\-groups [\fBeth\-phy\fP] [\fBeth\-mac\fP] [\fBeth\-ctrl\fP] [\fBrmon\fP] [\fBxdp\fP]
 Request groups of standard device statistics.
 .RE
 .TP
diff --git a/ethtool.c b/ethtool.c
index 33a0a492cb15..c1f1279bd9f0 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -5776,7 +5776,7 @@ static const struct option args[] = {
 		.nlchk	= nl_gstats_chk,
 		.nlfunc	= nl_gstats,
 		.help	= "Show adapter statistics",
-		.xhelp	= "               [ --all-groups | --groups [eth-phy] [eth-mac] [eth-ctrl] [rmon] ]\n"
+		.xhelp	= "               [ --all-groups | --groups [eth-phy] [eth-mac] [eth-ctrl] [rmon] [xdp] ]\n"
 	},
 	{
 		.opts	= "--phy-statistics",
-- 
2.31.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help