Thread (3 messages) flat view 3 messages, 2 authors, 2021-08-03

RE: [PATCH net-next] net: fec: fix MAC internal delay doesn't work

From: Joakim Zhang <hidden>
Date: 2021-08-03 02:01:28
Also in: lkml

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: 2021年8月3日 4:33
To: Joakim Zhang <redacted>
Cc: davem@davemloft.net; andrew@lunn.ch; netdev@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: fec: fix MAC internal delay doesn't work

On Fri, 30 Jul 2021 19:47:09 +0800 Joakim Zhang wrote:
quoted
@@ -3806,6 +3827,10 @@ fec_probe(struct platform_device *pdev)
 		fep->phy_interface = interface;
 	}

+	ret = fec_enet_parse_rgmii_delay(fep, np);
+	if (ret)
+		goto failed_phy;
You're jumping to the wrong label, it looks like phy_node needs to be released
at this point.
Yes, I will correct it. Thanks Jakub.

Best Regards,
Joakim Zhang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help