Re: [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable initializations
From: Joe Perches <joe@perches.com>
Date: 2021-08-02 08:35:42
Also in:
kernel-janitors, linux-wireless, lkml
On Sat, 2021-07-31 at 13:40 +0100, Colin King wrote:
From: Colin Ian King <redacted> The variables rtstatus and place are being initialized with a values that are never read, the initializations are redundant and can be removed.
trivia:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
[]
quoted hunk ↗ jump to hunk
@@ -1362,7 +1362,7 @@ u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl)132, 134, 136, 138, 140, 149, 151, 153, 155, 157, 159, 161, 163, 165 }; - u8 place = chnl; + u8 place; if (chnl > 14) { for (place = 14; place < sizeof(channel_all); place++) {
This line should probably be
for (place = 14; place < ARRAY_SIZE(channel_all); place++) {