Thread (14 messages) flat view 14 messages, 4 authors, 2021-08-04

Re: [PATCH 3/3] dt-bindings: net: rename Qualcomm IPQ MDIO bindings

From: <hidden>
Date: 2021-08-02 06:02:24
Also in: linux-arm-msm, linux-devicetree, lkml

On 2021-07-29 21:17, Andrew Lunn wrote:
quoted
@@ -23,7 +25,29 @@ properties:
     const: 0

   reg:
-    maxItems: 1
+    maxItems: 2
+
+  clocks:
+    items:
+      - description: MDIO clock
+
+  clock-names:
+    items:
+      - const: gcc_mdio_ahb_clk
+
+  resets:
+    items:
+      - description: MDIO reset & GEPHY hardware reset
+
+  reset-names:
+    items:
+      - const: gephy_mdc_rst
+
+  phy-reset-gpios:
+    maxItems: 3
+    description:
+      The phandle and specifier for the GPIO that controls the RESET
+      lines of PHY devices on that MDIO bus.
This is clearly not a rename. It is great you are adding missing
properties, but please do it as a separate patch.

	    Andrew
Hi Andrew, thanks for the comments, will separate it out in the next 
patch set.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help