RE: [RFC v3 net-next 1/2] rtnetlink: Add new RTM_GETEECSTATE message to get SyncE status

-----Original Message-----
From: Jakub Kicinski <kuba@kernel.org>
Sent: Monday, August 30, 2021 8:14 PM
To: Machnikowski, Maciej <redacted>
Subject: Re: [RFC v3 net-next 1/2] rtnetlink: Add new RTM_GETEECSTATE

quoted

+#define IF_EEC_PIN_UNKNOWN	0xFF
+
+struct if_eec_state_msg {
+	__u32 ifindex;
+	__u8 state;
+	__u8 src;
+	__u8 pin;
+	__u8 pad;
+};

Please break this structure up into individual attributes.

This way you won't have to expose the special PIN_UNKNOWN value to user
space (skip the invalid attrs instead).

Addressed all other comments. 
For this one - I'll add flags which will indicate validity of all values. Since 
this structure is self-contained and addresses the generic need for state 
report.

Will resubmit as a patch.

Thanks!
Maciek