Thread (25 messages) 25 messages, 4 authors, 2021-09-10

Re: [PATCH net-next 2/5 v2] net: dsa: rtl8366: Drop custom VLAN set-up

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-08-30 22:35:51

On Mon, Aug 30, 2021 at 11:48:56PM +0200, Linus Walleij wrote:
This hacky default VLAN setup was done in order to direct
packets to the right ports and provide port isolation, both
which we now support properly using custom tags and proper
bridge port isolation.

We can drop the custom VLAN code and leave all VLAN handling
alone, as users expect things to be. We can also drop
ds->configure_vlan_while_not_filtering = false; and let
the core deal with any VLANs it wants.

Cc: Vladimir Oltean <olteanv@gmail.com>
Cc: Alvin Šipraga <alsi@bang-olufsen.dk>
Cc: Mauri Sandberg <redacted>
Cc: DENG Qingfang <dqfext@gmail.com>
Signed-off-by: Linus Walleij <redacted>
---
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

Please keep this review tag when posting v3.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help